Open Romcol opened 4 years ago
@Romcol
Thanks for reporting this.
I also noticed that, I don't like this behavior but for me, it's a minor bug.
You're more than welcome to open a PR to fix that.
You can also invite your colleagues to like (👍) this issue so more 👍it has, it's more likely to be fixed by us.
Hi,
@piotr-s-brainhub Sure, I'll try to make a PR. Have you got any pointers on how to implement this?
I've seen that there's something such as an activeSlide
which is aligned to the left. We can prevent the user from selecting a slide past a certain slide maybe?
@Romcol
I'm not sure about an exact place in the code but generally, I guess, we should calculate whether there's a next slide to display and according to that allow or not to move right.
@piotr-s-brainhub has funded $7.00 to this issue.
I can reproduce it on 1.19.17
. Is it released?
@meysamizadmehr
not yet, if it was fixed, the GitHub issue would be closed
@Romcol
I leave the brainhubeu organization so I must remove the IssueHunt funding as it's only me who's able to manage these funds.
Moreover, the team decided on Thursday about stopping using IssueHunt.
@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $7.00) See it on IssueHunt
@Romcol
As your work is already on https://github.com/brainhubeu/react-carousel/pull/537, you can try reaching out @RobertHebel , @humbak or @Lukasz-pluszczewski or another brainhubeu organization member in order to be rewarded on IssueHunt.
Hi,
Cool. How should I reach you? Thanks
@Romcol We are working on restoring funding for already opened PRs. On the next Thursday, I will be able to re-assign money for this issue. Is it ok for you to wait for the funding one week?
Issuehunt for this issue will be restored tomorrow
@roberthebel has funded $7.00 to this issue.
@roberthebel has cancelled funding for this issue.(Cancelled amount: $7.00) See it on IssueHunt
Hi,
Having multiple items per page on the carousel we would expect the "next arrow" not to be clickable when the last item is shown. Currently, the arrow is clickable and also the carousel is draggable to the right as long as the last item is not aligned to the left. I think, as seen with other libs, we shouldn't be able to slide that far down the track.
To reproduce :
Remove
infinite
on this example : https://brainhubeu.github.io/react-carousel/docs/examples/multipleItems .Thank you for the lib :fire:
IssueHunt Summary
### Backers (Total: $0.00) ### Submitted pull Requests - [#536 [FIX] Limit reachable slide in Carousel](https://issuehunt.io/r/brainhubeu/react-carousel/pull/536) --- #### [Become a backer now!](https://issuehunt.io/r/brainhubeu/react-carousel/issues/501) #### [Or submit a pull request to get the deposits!](https://issuehunt.io/r/brainhubeu/react-carousel/issues/501) ### Tips - Checkout the [Issuehunt explorer](https://issuehunt.io/r/brainhubeu/react-carousel/) to discover more funded issues. - Need some help from other developers? [Add your repositories](https://issuehunt.io/r/new) on IssueHunt to raise funds.