Feature/pr 522 teaarte feature 519 on slide click

brainhubeu / react-carousel

A pure extendable React carousel, powered by Brainhub (craftsmen who ❤️ JS)

https://brainhub.eu/

MIT License

1.07k stars 164 forks source link

Feature/pr 522 teaarte feature 519 on slide click #523

Closed piotr-s-brainhub closed 4 years ago

piotr-s-brainhub commented 4 years ago

Deployed to https://beghp.github.io/gh-pages-rc-9
Fixes #519

- [x] an issue linked to the PR

piotr-s-brainhub commented 4 years ago

I checked this PR resolves the problem and doesn't break anything (desktop).

Video: https://recordit.co/1rwmXQ3YAk

piotr-s-brainhub commented 4 years ago

@teaarte

Unfortunately, I got negative feedback from my team about this PR. In some situations, there can be some problems with this callback.

Currently, we're doing a refactor to enable creating custom plugins for the react-carousel so when it's ready, you could publish your plugin for that. Before that, you have to use your own fork. You can merge the main repo to your fork whenever you want in order to have the newest bug fixes.