search

brainhubeu / react-carousel

A pure extendable React carousel, powered by Brainhub (craftsmen who ❤️ JS)
https://brainhub.eu/
MIT License
1.07k stars 164 forks source link

Displaying less thumbnails than total amount of thumbnails #588

Open briankosw opened 4 years ago

briankosw commented 4 years ago

Is your feature request related to a problem? Please describe. If a user wants to display lots of images in the carousel (e.g. display 100 images), it would be ill-advised to set the number parameter for Dots to 100 and display 100 thumbnails. If the user chooses a smaller number of thumbnails, such as 10, to display at once, then there should be a feature to swap out the thumbnails when the user clicks on the arrow button in the carousel and goes past the last image in the displayed thumbnails. Right now, it simply cycles back to the first image in the thumbnail.

Describe the solution you'd like One quick solution that I came up with is to keep two lists in the state. The first one is the master list of all thumbnails and the second one contains the thumbnails that are currently being displayed. Whenever the user clicks on the arrow buttons and goes to the next set of thumbnails, swap out the thumbnails in the second list by indexing on the master list.

piotr-s-brainhub commented 4 years ago

@briankosw

Thanks for your suggestion.

I invite you to open a PR. You can also invite your friends to like (👍) this issue, so more 👍 it has, it's more likely to be fixed by us.

However, currently, we're doing a major refactor so we want any new features to be implemented after the refactor.