search

brainhubeu / react-carousel

A pure extendable React carousel, powered by Brainhub (craftsmen who ❤️ JS)
https://brainhub.eu/
MIT License
1.07k stars 164 forks source link

Make TypeScript Definitions for carousel v2 #617

Open RobertHebel opened 4 years ago

RobertHebel commented 4 years ago

Is your feature request related to a problem? Please describe. Because of changes, we made in carousel v2 (removing props, adding new ones, adding plugins) we need to update our types definitions

Describe the solution you'd like An updated version of d.ts for carousel v2 in https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/brainhubeu__react-carousel

RobertHebel commented 4 years ago

Currently, types for v2 are accessible on this repo https://github.com/RobertHebel/DefinitelyTyped/tree/master/types/brainhubeu__react-carousel

After v2 release, I will create PR for DefinitlyTyped repo

wilo087 commented 4 years ago

@RobertHebel Would you explain how use Types from this repo?

Could you give me an example?

RobertHebel commented 4 years ago

I've created PR with new typings for carousel 2.0 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/46433

RobertHebel commented 4 years ago

@wilo087, For now, if you want to use types for carousel 2.0 you need to add your own declarations, or you can use carousel v1 which already has typescript support