brainlag / JavaNSQClient

Fast Java client for NSQ

MIT License

90 stars 57 forks source link

Unexpected network errors will cause consuming stop #27

Closed icanfly closed 7 years ago

icanfly commented 8 years ago

Consumer never be triggered about network error. For example, unplug the network cable, disable computer networks. so connections in consumer never be closed and remove.

I think should add heartbeat interval expire for connection. If last heartbeat interval exceeded, close and reconnection.

I will post my code improvements soon.

icanfly commented 8 years ago

code like this: https://github.com/brainlag/JavaNSQClient/pull/28

brainlag commented 7 years ago

28 was merged so this should be fixed.