search

brainlag / JavaNSQClient

Fast Java client for NSQ
MIT License
90 stars 57 forks source link

37: compatibility with NSQ v1.0.0-compact #38

Closed vic0075 closed 7 years ago

vic0075 commented 7 years ago

37: accommodate changes in nsq v1.0.0-compact, also provided backward compatibility

Api call for discovery (/lookup?topic=XXX) has been changed in NSQ v1.0.0-compact (although they've not updated their webpage yet)

Response in NSQ prior to v1.0.0-compact { status_code: 200, status_txt: "OK", data: { channels: [ ], producers: [ { remote_address: "127.0.0.1:39310", hostname: "vikash.tiwari", broadcast_address: "vikash.tiwari", tcp_port: 4150, http_port: 4151, version: "0.3.8" } ] } }

Response in NSQ v1.0.0-compact { channels: [ "emailChannel" ], producers: [ { remote_address: "127.0.0.1:40258", hostname: "vikash.tiwari", broadcast_address: "vikash.tiwari", tcp_port: 4150, http_port: 4151, version: "1.0.0-compat" } ] }

I have also created the documentation issue https://github.com/nsqio/nsq/issues/870

vic0075 commented 7 years ago

@brainlag: I have reverted the changes from pom.xml and README.md for version thing. I guess, you guys update it when you release a new version for this.

vic0075 commented 7 years ago

@brainlag: if possible, can you please create an artifact, I really need it in my project and I don't want to do work around.

vic0075 commented 7 years ago

@brainlag Gentle Reminder, Please create a new artifact version and close the issue: https://github.com/brainlag/JavaNSQClient/issues/37