NSQConsumer timing logic change

brainlag / JavaNSQClient

Fast Java client for NSQ

MIT License

90 stars 57 forks source link

NSQConsumer timing logic change #5

Closed mguindin closed 8 years ago

mguindin commented 8 years ago

Changing repeatable tasks in NSQConsumer to use ScheduledThreadExecutor instead of Timer.
Adding ability to schedule methods to use timer in NSQConsumer (useful for keeping NSQMessageCallback stateless and using NSQConsumer to flush)

These changes were useful for us for integrating NSQ with Scala and Spark.

brainlag commented 8 years ago

I will merge most of this. (Skipping the sbt file) But I don't like how we handle nsqd lookups work right now. Because right now you can't register a consumer on a topic which does not exist and since nsq creates topics on the fly this should work.