Add dialyxir and specify field types of structs

brainlid / langchain

Elixir implementation of a LangChain style framework.

https://hexdocs.pm/langchain/

Other

510 stars 58 forks source link

Add dialyxir and specify field types of structs #13

Closed RudolfMan closed 8 months ago

RudolfMan commented 9 months ago

Dialyzer was able to find some errors in specs and even suggest a bugfix 🙂

RudolfMan commented 9 months ago

Dialyzer also suggests that this clause will never happen, but I hesitated to propose to delete as is for now https://github.com/brainlid/langchain/blob/95217c19ea81515b119355f25be66e6b5c2f3bb6/lib/chains/llm_chain.ex#L400-L403

brainlid commented 8 months ago

Thank you for the work and interest in helping the project. At this time, I'm not focusing on expanded Dialyzer support. I don't want to leave you or the PR hanging in limbo, so for now, I'm going to close it. Thank you though for your interest!