Closed medoror closed 8 months ago
@medoror, Maybe editing your PR message to also add Closes #5
? (This would enable automatically closing the related issue).
One thing that I noticed, we don't have CI for this project yet, would it be desirable to add a simple one to ensure there's no regression on PRs, @brainlid ?
@Cardosaum I went ahead and added the basic CI test runs. Note, it does not, and will not, run live tests against external services.
Thanks for the suggestion to finally push me to do it. :)
The tests on main seem to be broken at the moment. I did validate that running
mix test --include live_call
before and after the req upgrade resulted in the no change to test output