brainlife / cli

brainlife.io Command Line Interface (CLI)
https://brainlife.io
MIT License
2 stars 5 forks source link

Feature requests & bugfixes: bl-dataset-bidsupload.js #40

Closed kathrynalpert closed 5 years ago

kathrynalpert commented 5 years ago

Feature requests:

Bugfixes:

francopestilli commented 5 years ago

@kathrynalpert thanks! @stevengeeky

soichih commented 5 years ago

I've added support for sessions, and fixed those bugs. I haven't updated to allow links, however.

@kathrynalpert What files are linked exactly? The directories, or the files? Or maybe both? Are they symlinks or hardlinks?

kathrynalpert commented 5 years ago

[Sorry for my delayed reply - I wasn't receiving notifications, but should be now.]

@soichih In my case, the links are symlinks to files, and it seems that your new code (1.2.38) works with them!

kathrynalpert commented 5 years ago

One comment about session handling: The upload works beautifully and the main "datasets" tab has the sessions listed nicely. However, when I'm staging datasets for processing, only the subject ID is visible (see screenshot, I'm talking about how to distinguish between last two datasets), so I have to use timestamp to determine which session I'm selecting. It'd be great if the session were visible here, too (or even better, if I could filter by session).

screen shot 2018-10-11 at 12 56 37 pm
soichih commented 5 years ago

@kathrynalpert Thanks for the feature request. I've added session labels on the dataset selecter and a few other places. Please let me know if you notice anywhere else that I should display it. By the way, you can use this repo for posting Brainlife UI issue / requests > https://github.com/brain-life/warehouse/issues

kathrynalpert commented 5 years ago

Fabulous changes! I'm closing this issue and will make UI requests there in future.