search

brainlife / ezbids

A web service for semi-automated conversion of raw imaging data to BIDS
https://brainlife.io/ezbids
MIT License
26 stars 13 forks source link

SeriesNumber / series_id mapping is wrong with analyzer.py #21

Closed soichih closed 3 years ago

soichih commented 3 years ago

I have 3 unique series detected by analyzer.

image

The first one (series_id 0) contains SeriesNumber 3, The second one (series_id 1) contains SeriesNumber 4 The last one (series_id 2) contains SeriesNumber 5.

However, when I go to object mapping page, I see an object with SeriesNumber 5 using series_id 1 - instead of 2.

image

Also, I see the phantom series with SeriesNumber 7 (which doesn't exist in the series page) showing up on the override page and it's using series_id 1 which is for SeriesNumber 4.

image

I think something is broken with analyzer.py.

dlevitas commented 3 years ago

Issue is that variables series_id and SeriesNumber represent two separate things, but are confusing to user and can lead to improper entries on the UI. Solution is to rename series_id to series_idx