brainlife / ezbids

A web service for semi-automated conversion of raw imaging data to BIDS
https://brainlife.io/ezbids
MIT License
26 stars 13 forks source link

SeriesNumber should not exist in object #22

Closed soichih closed 3 years ago

soichih commented 3 years ago

I've noticed that analyzer.py is setting SeriesNumber at the Object (capitalizing it to distinguish from Javascript "object") level.

image

The information about series should come from series object by looking up the series list using series_id as array index. There were a few places in UI that were using SeriesNumber stored in Object, so I have corrected it to use series_id to lookup series object instead..

analyzer.py should also be updated to stop storing SeriesNumber at the object level to avoid future issues.