search

brainlife / ezbids

A web service for semi-automated conversion of raw imaging data to BIDS
https://brainlife.io/ezbids
MIT License
26 stars 13 forks source link

Recommend updating Niivue #48

Closed hanayik closed 2 years ago

hanayik commented 2 years ago

@soichih, I would recommend updating Niivue to the most recent version on npm. There have been significant changes that make Niivue more robust, and tolerant of NIFTI files stored in various orientations. The 3D rendering has also been updated. Lastly, a new options exists to disable drag and drop file loading on the canvas. This is useful if you don't want users to accidentally drop a file on the canvas (which would replace the image).

soichih commented 2 years ago

Thanks for letting me know! We've updated it to 0.21.1. The UI doesn't look all too different, but do we need to adjust the niivue config parameters?

image

Here is our current config parameters

https://github.com/brainlife/ezbids/blob/master/ui/src/components/niivue.vue#L46

hanayik commented 2 years ago

Great! The UI should be the same (font size may be slightly smaller, but that is fixed in 0.21.2). 0.21.2 will have a new option “dragAndDropEnabled: true”. From that version on, if you don’t want users to somehow accidentally drop a link or nifti file onto the canvas, you could set that option to false when you create a Niivue instance.

https://niivue.github.io/niivue/devdocs/Niivue.html#Niivue

From: Soichi Hayashi @.> Date: Thursday, 3 March 2022 at 4:54 pm To: brainlife/ezbids @.> Cc: Taylor Hanayik @.>, Author @.> Subject: Re: [brainlife/ezbids] Recommend updating Niivue (Issue #48)

Thanks for letting me know! We've updated it to 0.21.1. The UI doesn't look all too different, but do we need to adjust the niivue config parameters?

[image]https://user-images.githubusercontent.com/923896/156612431-2e97261f-1377-41d2-a8c2-ebd0c4f0fd55.png

Here is our current config parameters

https://github.com/brainlife/ezbids/blob/master/ui/src/components/niivue.vue#L46

— Reply to this email directly, view it on GitHubhttps://github.com/brainlife/ezbids/issues/48#issuecomment-1058256992, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABHZ3OFTUO4KZJKWZFH4YM3U6DVDNANCNFSM5P2G7EAA. You are receiving this because you authored the thread.Message ID: @.***>

hanayik commented 2 years ago

@soichih , it would be good to actually update again. Sorry about that, we had a 3D rendering bug introduced recently that was only showing up on certain devices. That bug has been fixed now. The latest Niivue should be used. The useful enabling/disabling of drag and drop is also now supported: https://github.com/niivue/niivue/blob/351cff117f04e7cd1d70c7868746fd4633569831/src/niivue.js#L83

soichih commented 2 years ago

OK will do! I've asked @dlevitas to help up update/reconfigure this time around.

dlevitas commented 2 years ago

Hi @hanayik Niivue should now be updated on ezBIDS.

Thanks for reaching out.