search

brainpad-board / brainpad-pulse

BrainPad Pulse
https://makecode.brainpad.com/
Other
0 stars 1 forks source link

tilting #41

Open pelikhan opened 2 years ago

pelikhan commented 2 years ago

Diff https://github.com/brainpad-board/brainpad-pulse/blob/3ce19c44a1257fc8da85e05179ced5d262a661e6/libs/accelerometer/sim/accelerometer.ts#L402 and https://github.com/microsoft/pxt-common-packages/blob/master/libs/accelerometer/sim/accelerometer.ts#L402 to see if you're missing something in that code.

Palomino34 commented 2 years ago

Thank you. We did take a look on that few days ago. Looks to us that we don't use "brainpad-pulse/libs/accelerometer/sim/accelerometer.ts".

We use directly the one from pxt-common-packages. The reason we say that because we don't see pxt.json include the local one. Also, changed local one didn't effect. But changed the file from "pxt-common-packages" it has effect.

We know how to disable, enable it. But we don't know when enable/disable. Meaning we don't know when user uses accelerometer or not. Is there any property that we can read or catch?

Larger, how do we know if user use a special block in their app?

Thank a lot.

pelikhan commented 2 years ago

Somehow you have some typescript code that is calling an accelerometer API. If you do not need the local file, delete it. It will lead to confusion.

From: Palomino34 @.> Sent: Wednesday, November 17, 2021 5:38:45 AM To: brainpad-board/brainpad-pulse @.> Cc: Peli de Halleux @.>; Author @.> Subject: Re: [brainpad-board/brainpad-pulse] tilting (Issue #41)

Thank you. We did take a look on that few days ago. Looks to us that we don't use "brainpad-pulse/libs/accelerometer/sim/accelerometer.ts".

We use directly the one from pxt-common-packages. The reason we say that because we don't see pxt.json include the local one. Also, changed local one didn't effect. But changed the file from "pxt-common-packages" it has effect.

We know how to disable, enable it. But we don't know when enable/disable. Meaning we don't know when user uses accelerometer or not. Is there any property that we can read or catch?

Larger, how do we know if user use a special block in their app?

Thank a lot.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbrainpad-board%2Fbrainpad-pulse%2Fissues%2F41%23issuecomment-971591511&data=04%7C01%7Cjhalleux%40microsoft.com%7C348a6711cd6d49df371108d9a9cf946b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637727531300707821%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YaPVBz9aPvCpzsahF0eZam1dwJ7S1oE4zaTNU6%2B9%2B1Q%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKIANCNYXSREMSZEEU3UMOV6LANCNFSM5IE6WBFA&data=04%7C01%7Cjhalleux%40microsoft.com%7C348a6711cd6d49df371108d9a9cf946b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637727531300717812%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=VYqintYtDC27rD4d1Rsgqql5acYT0oCyR3XE1vHoq20%3D&reserved=0.