brainrom / kokovp

Modern video player based on libmpv and Qt
GNU General Public License v2.0
8 stars 1 forks source link

Suggestions and issues. #6

Open adolfotregosa opened 2 weeks ago

adolfotregosa commented 2 weeks ago

First of all, thank you for your video player. I'm gonna leave my requests that I miss and hopefully will be useful to other people. It will mostly be things that I immediately miss coming from smplayer.

global volume: The fact that kokovp always start at 50% is a nuisance. Make it remember the volume or make it global. image

subtitle track: This I solely miss especially when watching anime with several subtitles tracks. image

For what ever reason, kokovp does not remember window size when closed. I can force it to remember using KDE windows rules but, it should do it by itself. For me it always opens like this and I assume "kokovp" is supposed to be middle aligned. image image

Seek to position while dragging is not working for me ? Both do the same thing. image

Video options are .. : image vs image

It should be possible to click the seek bar anywhere and jump video to where you clicked. Seeking with the keyboard is very slow. I have 2 seconds set for shot jump. If I keep my left or right key pressed in, the seek performance is for lack of a better wording, bad. It does not react, it stumbles and lags instead of keep seeking instantly. I miss some kind of visible chapter marker, somewhere.

How do we customize "mpv" options ? Some I use e.g: video-sync=display-resample interpolation-threshold=3 interpolation

Thank you for your time on this project. Keep at it. It's already awesome :)

brainrom commented 1 week ago

Split to the different issues: #7, #9, #10, #11, #12

when watching anime with several subtitles tracks

Because different series, suitable subtitle/audio track number is different, so I think it's better to re-use track numbers on the next video in the play queue, when the option is enabled. If player is stopped (using Stop action), then player's language preferences is used. This behavior allow to select track in the uniform way, instead of reconfiguring player itself for the certain series. If you continue watching later, after player is closed, and then just open the episode, where you stopped, player also reuse the tracks numbers on the next episode, because on already opened episode tracks numbers is saved in cache file.

Seeking with the keyboard is very slow. I have 2 seconds set for shot jump. If I keep my left or right key pressed in, the seek performance is for lack of a better wording, bad. It does not react, it stumbles and lags instead of keep seeking instantly.

I can't reproduce the issue completely. Please test it when video is paused. If it only happens when video is playing, then it can be fixed.

Video options

Why do you want select hardware decoding backend? According to my tests, mpv always select the best decoding engine. What is the case, when manual configuration is needed?

Thank you.

adolfotregosa commented 1 week ago

can't reproduce the issue completely. Please test it when video is paused. If it only happens when video is playing, then it can be fixed.

While playing, It does not seek smoothly if I keep the key pressed in. It lags and when I lift key it freezes for some time. Haven't tried paused.

Add the UI function to be able to click seek bar to jump video to that location.

Why do you want select hardware decoding backend? According to my tests, mpv always select the best decoding engine. What is the case, when manual configuration is needed?

Having options available when something goes wrong is easier to diagnose.

Please add the option to select default subtitle track. In my experience it is useful in real world usage. I wouldn't have suggested the option if I didn't use it.