search

brainstorm-tools / brainstorm3

Brainstorm software: MEG, EEG, fNIRS, ECoG, sEEG and electrophysiology
http://neuroimage.usc.edu/brainstorm
GNU General Public License v3.0
384 stars 162 forks source link

[bugfix] panel_ieeg #701

Closed chinmaychinara91 closed 5 months ago

chinmaychinara91 commented 6 months ago

Issue-1: If implantation is started and there is a 3DMRI+isosurface figure open, unexpected things happens. Solution: https://github.com/brainstorm-tools/brainstorm3/pull/701/commits/fad6568ee413e061af912e16c8270a3d836fdab6

Issue-2: Double-clicking on the SEEG/ECOG ("number of channels") channel file in the functional tab only opens the cortex figure for ECOG and ECOG+SEEG. Solution: https://github.com/brainstorm-tools/brainstorm3/pull/701/commits/9452f2f21fc3685b2ff60ae9705360b7246bc8cc

Discussion: https://neuroimage.usc.edu/forums/t/display-sensors-cortex-opens-mri-viewer-in-addition-to-cortex-view/46083/2 Do we need to have MRI Viewer display for all surface types by default ? If no then this is the proposed solution: https://github.com/brainstorm-tools/brainstorm3/pull/701/commits/3ccd367251ad92d75fde12d652c21427ebd45c0e

Issue-3: Reported in https://neuroimage.usc.edu/forums/t/ieeg-panel-error/46550. Solution: 30e5648

rcassani commented 6 months ago

Discussion: https://neuroimage.usc.edu/forums/t/display-sensors-cortex-opens-mri-viewer-in-addition-to-cortex-view/46083/2 Do we need to have MRI Viewer display for all surface types by default ? If no then this is the proposed solution: https://github.com/brainstorm-tools/brainstorm3/commit/3ccd367251ad92d75fde12d652c21427ebd45c0e

This was introduced in #699 with the commit 60cc127 to patch another bug.

https://github.com/brainstorm-tools/brainstorm3/pull/699/commits/60cc1273f879314276f61f2edae683b4689eeb22

rcassani commented 5 months ago

This PR has been closed without merging.

The idea is to refactor the IEEG updated features in one PR, to properly address these issues, and others. See #710