search

brainsum / drupal-dev-tools

Tools for Drupal development.
5 stars 1 forks source link

Depracated warning with Php 7.3 - update grumphp #17

Closed szatom closed 5 years ago

szatom commented 5 years ago

PHP Deprecated: strpos(): Non-string needles will be interpreted as strings in the future. Use an explicit chr() call to preserve the current behavior in /vendor/phpro/grumphp/src/Locator/ConfigurationFile.php on line 75

In grumphp it's already fixed, released in the v0.15.0 : https://github.com/phpro/grumphp/releases

We should depend on grumphp: ^0.15.0

mhavelant commented 5 years ago

Note, "matcher" has been removed from git commit/branch name tasks, manual update is required when importing the supplied grumphp.yml.

Before:

parameters:
    convention.git_commit_message_matchers: ['/^([A-Z]+-[\d]+ )+\| [A-Za-z\d\s\.]+([^.])+\.{1}$/s']

After:

parameters:
    convention.git_commit_message_whitelist: ['/^([A-Z]+-[\d]+ )+\| [A-Za-z\d\s\.]+([^.])+\.{1}$/s']