Increase Discover Card Range to 19 Digits

braintree / android-card-form

A ready-made card form layout that can be included in your Android app, making it easy to accept credit and debit cards.

MIT License

366 stars 130 forks source link

Increase Discover Card Range to 19 Digits #108

Closed sarahkoop closed 3 years ago

sarahkoop commented 3 years ago

Summary of changes

Increase valid Discover card length to 19 digits

Checklist

[x] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sarahkoop

sarahkoop commented 3 years ago

This change works fine in card form alone - but the Drop-in auto transition logic transitions immediately when a valid card is entered (so if a user's card number is valid at 16 digits, they won't be able to enter the full 19). I'm not sure how likely that is, or if this is ok to merge to card form and revisit the issue when used in Drop-in.

sarahkoop commented 3 years ago

I've drafted a Drop-in PR that changes the auto-transition logic to navigate if the card is valid and the max length for the type. This aligns with iOS Drop-in.