KEY For Security Flag - Githubissues

braintree / android-card-form

A ready-made card form layout that can be included in your Android app, making it easy to accept credit and debit cards.

MIT License

366 stars 130 forks source link

KEY For Security Flag #111

Closed phelipelopesc closed 2 years ago

phelipelopesc commented 2 years ago

Thank you for your contribution to Braintree.

Before submitting this PR, note that we cannot accept language translation PRs. We support the same languages that are supported by PayPal, and have a dedicated localization team to provide the translations. If there is an error in a specific translation, you may open an issue and we will escalate it to the localization team.

Summary of changes

key for enable or disable secure Flag.

Checklist

[ ] Added a changelog entry

Authors

phelipelopesc

sarahkoop commented 2 years ago

Hi @phelipelopesc thanks for opening this PR. Can you provide more information on why the ability to disable this flag is needed? Since this is a security flag, it's not necessarily something we want to allow merchants to disable.

phelipelopesc commented 2 years ago

Hi @sarahkoop in my case i need disable that to show/record screen in my company. In first time i did disable on debug mode, but i don't know if is the better way.

sshropshire commented 2 years ago

@phelipelopesc I understand the concern here. Unfortunately, allowing this flag to be disabled poses a security risk for merchant apps using the Braintree SDK. I would recommend distributing a debug version to internal stakeholders who need to see the app.