Closed sarahkoop closed 2 years ago
@sarahkoop this is awesome. I noticed an alignment change from left
to centered
of the available card types on DropIn, is that a result of the new AccessibleSupportedCardTypesView
?
@sarahkoop this is awesome. I noticed an alignment change from
left
tocentered
of the available card types on DropIn, is that a result of the newAccessibleSupportedCardTypesView
?
Yeah that's a result of using FlexboxLayoutManager
within AccessibleSupportedCardTypesView
where I set JustifyContent.CENTER
on the flexbox layout programatically. If we want the flexibility to align center in card form and align left in Drop-in I could make that a param. I preferred the centering visually - what do you think?
@demerino I wasn't able to find a good example of this to compare, but I did test grouping the cards together for the screen reader. I think that would take a little more investigation since it caused some unusual tab navigation behavior in Drop-in. I can create a card to look into that further in the future.
Summary of changes
AccessibleSupportedCardTypesView
and deprecateSupportedCardTypesView
CardForm with SupportedCardTypesView
CardForm with AccessibleSupportedCardTypesView
Drop-in with SupportedCardTypesView
Drop-in with AccessibleSupportedCardTypesView
Checklist
Authors