Don't proguard the whole design library

braintree / android-card-form

A ready-made card form layout that can be included in your Android app, making it easy to accept credit and debit cards.

MIT License

366 stars 128 forks source link

Don't proguard the whole design library #29

Closed consp1racy closed 7 years ago

consp1racy commented 7 years ago

I'm above the dex limit so your problem became my problem :D

Use proguard as a precision tool, pretty sure card-form doesn't need everything from the design library. And if it does need something it's going to be kept anyway.

Secondly the library should depend on the oldest support library it can do with. See https://stackoverflow.com/questions/42949974/android-support-repo-46-0-0-with-android-studio-2-3/42957234#42957234

lkorth commented 7 years ago

I tried to amend the PR to fix a merge conflict when removing the dependency ranges, but it appears to have gone sideways in the GitHub UI. The change to remove the design library from the consumer Proguard file is now on master @ 8f1c373686313345c18773c99445ea44839a3e58. Thanks for your contribution @consp1racy!

I'll address dependency ranges in braintree/braintree-android-drop-in#38 shortly.