search

braintree / android-card-form

A ready-made card form layout that can be included in your Android app, making it easy to accept credit and debit cards.
MIT License
366 stars 128 forks source link

Provided card.io #31

Closed Jawnnypoo closed 7 years ago

Jawnnypoo commented 7 years ago

Heya,

This makes the card.io dependency provided instead of compile so that it is an optional include.

This forces users to include the compile statement if they want to use card.io, which is what the README already implies.

This also adds a plugin to check the dependencies to see if they have updates. Run with ./gradlew dependencyUpdates

lkorth commented 7 years ago

Thanks for the PR @Jawnnypoo.

card.io is already an optional dependency, when the pom file is generated it's marked as optional.

Jawnnypoo commented 7 years ago

Ahhh I missed that! I suppose using provided would be a more direct way of doing this, but good to know it's already working!

lkorth commented 7 years ago

It used to be that you couldn't use provided in library modules for aars, but that appears to have changed.

It might be clearer in the future to use provided, but for now it works with the optional dependency.

Jawnnypoo commented 7 years ago

:+1: