braintree / android-card-form

A ready-made card form layout that can be included in your Android app, making it easy to accept credit and debit cards.
MIT License
366 stars 127 forks source link

name in form #9

Closed dhavalsharma closed 8 years ago

dhavalsharma commented 8 years ago

Hi,

Is there a plan to add full name in form ?

thx

lkorth commented 8 years ago

@dhavalsharma the form is pretty extensible and you can easily create an EditText that extends FloatingLabelEditText and get the same appearance for free. You can also add some additional validations to your EditText if you wish. There are currently no plans to add an additional field like name, however pull requests are welcome.

dhavalsharma commented 8 years ago

thx @lkorth

TheLester commented 8 years ago

@lkorth Can you please explain why FloatingLabelEditText must be wrapped in ViewGroup. Its seems like some ugly hack

lkorth commented 8 years ago

There was a conflict with the view and it's parent view.