Deprecate expiration date picker dialog/keyboard

braintree / android-card-form

A ready-made card form layout that can be included in your Android app, making it easy to accept credit and debit cards.

MIT License

366 stars 130 forks source link

Deprecate expiration date picker dialog/keyboard #94

Closed scannillo closed 4 years ago

scannillo commented 4 years ago

Why

This GH Issue revealed a UI bug with our custom expiration date picker on Android 11 Beta.

Changes

Deprecate useDialogForExpirationDateEntry() so merchants can no longer opt into using the broken custom expiration date keyboard.
Changed default expiration date keyboard to use a system numeric keyboard.
Updated cvv keyboard to be numeric only.

Authors

@sshropshire @scannillo

Reviewers

@braintree/team-sdk

billwerges commented 4 years ago

If we're already making a breaking change by modifying the useDialog default value, why are we only deprecating the useDialogForExpirationDateEntry method and not removing it entirely?

If it doesn't work on newer versions of Android, we should either fix or remove it rather than continuing to ship a broken component that just defaults to being off.

sshropshire commented 4 years ago

@billwerges @sestevens Sammy had the same thought and I agree we can remove. Removed!