search

braintree / braintree-android-drop-in

Braintree Drop-In SDK for Android
https://developers.braintreepayments.com/guides/drop-in/android/v2
MIT License
124 stars 78 forks source link

No result on user dismiss #346

Closed paolomanca closed 2 years ago

paolomanca commented 2 years ago

General information

Issue description

On version 6.1.0 I don't receive any result when the user dismisses the drop in. I think the intended behaviour was to return a DropInResult with UserCanceledException from DropInListener#onDropInFailure. However, in DropInActivityResultContract#parseResult this logic is conditioned to intent != null, which is always false for RESULT_CANCELED, leading to no result being produced.

sshropshire commented 2 years ago

@paolomanca thanks for using the Braintree SDK for Android and for filing this bug! This is a great catch, there was an oversight with the unit test scaffolding. We've created a PR and hope to have this fix out soon.

paolomanca commented 2 years ago

Hi @sshropshire, do you have an ETA for a release?

sshropshire commented 2 years ago

@paolomanca thank you for your patience. We don't have an exact ETA but there are some additional fixes we're looking to get merged in. Once those are approved/merged we'll push a release.