braintree / braintree-android-google-payment

Google Payment component for our Braintree AndroidSDK
MIT License
3 stars 10 forks source link

Add Support for GooglePay's existingPaymentMethodRequired Field #10

Closed sshropshire closed 4 years ago

sshropshire commented 4 years ago

Add Support for GooglePay "Existing Payment Method"

Summary of changes

Authors

List GitHub usernames for everyone who contributed to this pull request.

fcastagnozzi-ta commented 4 years ago

Any chance of merging this? I need to set this same flag and was thinking of opening my own PR for it before I found this one.

sestevens commented 4 years ago

Any chance of merging this? I need to set this same flag and was thinking of opening my own PR for it before I found this one.

@fcastagnozzi We're working on getting this across the finish line 🏁

fcastagnozzi-ta commented 4 years ago

Awesome, will you be doing a release for this? I tried grabbing a snapshot artifact but it doesn't look like any have been published for nearly a year.

scannillo commented 4 years ago

Awesome, will you be doing a release for this? I tried grabbing a snapshot artifact but it doesn't look like any have been published for nearly a year.

We're working toward a release soon. We will update you once it releases.

scannillo commented 4 years ago

Hey @fcastagnozzi, this was released in version 3.3.0.

fcastagnozzi-ta commented 4 years ago

@scannillo Bad news, this doesn't seem to work and always returns false for me. The resulting json ends up being something like:

  "apiVersion": 2,
  "apiVersionMinor": 0,
  "allowedPaymentMethods": [{
    "type": "CARD",
    "parameters": {
      "allowedAuthMethods": ["PAN_ONLY", "CRYPTOGRAM_3DS"],
      "allowedCardNetworks": ["visa", "mastercard", "amex"]
    }
  }],
  "existingPaymentMethodRequired": true
}

but I couldn't get it to return true unless I changed the card names to all CAPS.