braintree / braintree-android-google-payment

Google Payment component for our Braintree AndroidSDK

MIT License

3 stars 10 forks source link

Update Javadoc Links #12

Closed sshropshire closed 4 years ago

sshropshire commented 4 years ago

Update Javadoc Links

Summary of changes

Remove javadoc links to external projects.
Make PaymentMethodNonceFactory extractPaymentMethodToken method package private.

Checklist

~[ ] Added a changelog entry~

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sestevens @sshropshire

scannillo commented 4 years ago

Can you clarify why we're Removing javadoc links to external projects?

What is wrong with having

{@link #isReadyToPay(BraintreeFragment, BraintreeResponseListener)}

in our dev docs here? Just need a little more clarification.

sestevens commented 4 years ago

We're removing

{@link #isReadyToPay(BraintreeFragment, BraintreeResponseListener)}

because it's linking to the method to user is already looking at. So the link doesn't go anywhere.

We removed some links to things that aren't in the BT Google Pay module because javadocs doesn't know how to link to things outside of the current project.

So basically, we cleaned up links that were broken and/or didn't do anything useful.