braintree / braintree-android-google-payment

Google Payment component for our Braintree AndroidSDK
MIT License
3 stars 10 forks source link

Google Payment Client #20

Closed sshropshire closed 3 years ago

sshropshire commented 3 years ago

Summary of changes

Authors

sestevens commented 3 years ago

Two general thoughts/questions:

  1. How does everyone feel about the term GooglePayment that's used on a lot of these class names? It's always seemed slightly weird to me, since the payment method is "Google Pay" not "Google Payment". Would it make sense to change it to GooglePayClient, GooglePayException, etc. or would that conflict with Google's APIs?

  2. At one point we talked about moving this library into the main repo, alongside the rest of the payment methods. Would it make sense to do that now? I'd be in favor of having one less repo to worry about.

sshropshire commented 3 years ago

@sestevens Sarah and I agree with both points. Talking it through:

  1. How does everyone feel about the term GooglePayment that's used on a lot of these class names? It's always seemed slightly weird to me, since the payment method is "Google Pay" not "Google Payment". Would it make sense to change it to GooglePayClient, GooglePayException, etc. or would that conflict with Google's APIs?

GooglePay is the name of the product and Braintree offers it as a feature of the SDK. Having the names align would be less confusing.

  1. At one point we talked about moving this library into the main repo, alongside the rest of the payment methods. Would it make sense to do that now? I'd be in favor of having one less repo to worry about.

This would be awesome. Jumping around the different repos requires some wrangling. We'd be up for both changes if we're cool with the version updating for all modules on deploy, or if we could come up with an alternative to keep each module's semver isolated that'd be cool too.