search

braintree / braintree-android-google-payment

Google Payment component for our Braintree AndroidSDK
MIT License
3 stars 10 forks source link

Add countryCode to support 3DS 2 #6

Closed Epreuve closed 3 years ago

Epreuve commented 5 years ago

This looks to add a missing field required for SCA/3DS 2 to Google Pay as dictated here in the Google Docs

crookedneighbor commented 5 years ago

Maybe as a separate PR, but are there docs we can add for 3DS flows to the reference docs? (possibly in the main sdk instead of this one? not sure)

sestevens commented 4 years ago

Should we add a changelog entry?

Epreuve commented 4 years ago

Should we add a changelog entry?

We'd need to give the Rakefile the same attention (to remove the changelog method) first

sestevens commented 4 years ago

Got it. We can prolly do that one of these days.

sestevens commented 4 years ago

@Epreuve Just saw that this is still open. Should we merge it?

scannillo commented 4 years ago

Should we add a changelog entry?

We'd need to give the Rakefile the same attention (to remove the changelog method) first

This was fixed: https://github.com/braintree/braintree-android-google-payment/commit/45f4ee3e27ff2cd7b7f4f38299635e745d7cabf9

scannillo commented 4 years ago

I checked in with @Epreuve on the status of the PR. We will hold off on merging for now.

This PR came from what was a workstream for supporting SCA on Google Pay. We were asked by BT gateway teams to hold off on merging. That workstream internally has not had any motion since this PR. No E2E testing was done yet, so we will hold off on merging this as we cannot guarantee it won't break merchants integrations.

morganlutz commented 3 years ago

Hi all / @scannillo, what is the status of this PR? We received a warning that the temporary solution (inferring country code from currency) is only in place for the next 6 months. We must send the country code to avoid declined transactions. Here is part of the warning we received from Google:

To avoid a poor user experience and unnecessary declines we will infer a country code from the relevant information you provide us, such as the currency of the transaction. Should that currency be from a relevant EEA market where SCA is being enforced, this will enable you to receive a SCA compliant payment credential.

This is a temporary measure and we only plan to infer the country code or a maximum of 6 months, to assist with your SCA readiness. You can of course override this temporary measure by updating your Google Pay API integration and returning a country code in ‘transactionInfo.countryCode’.

sestevens commented 3 years ago

Hi @morganlutz Thanks for reaching out about this issue! We don't have an answer for you at the moment, but we're looking into it.

sestevens commented 3 years ago

@morganlutz I confirmed with the team that this functionality should be added. I don't have an exact timeframe at the moment, but we'll work on getting this PR merged in.