search

braintree / braintree-android-google-payment

Google Payment component for our Braintree AndroidSDK
MIT License
3 stars 10 forks source link

Bump core SDK version, Fix BuildConfig version reference #8

Closed Epreuve closed 4 years ago

Epreuve commented 4 years ago

This bumps the core SDK dependency version to the current version to include 3DSecure, in the event it's required.

It also fixes an issue where the wrong SDK version was being passed to various fields. This was coincidentally correct as the base SDK version matched the version of the google pay module. When the no longer matched, the bug presented itself.

sestevens commented 4 years ago

Are there tests for GooglePayment.java? Could we update them (or add some)?

sestevens commented 4 years ago

Oh, I just saw that the tests are in a different repo. Just for my understanding - why don't the tests for this class live here?

Epreuve commented 4 years ago

Oh, I just saw that the tests are in a different repo. Just for my understanding - why don't the tests for this class live here?

Good question. The unit tests do live in this repo, but the integration tests are in the braintree-android repo. That's because we can leverage the existing mocks/helpers that already exist there, and not have to duplicate code here since the SDK is consuming this module anyway.