braintree / braintree-ios-drop-in

Braintree Drop-in for iOS
https://developers.braintreepayments.com
MIT License
98 stars 77 forks source link

Deprecated UIWebView API usage #193

Closed tobynguyen closed 4 years ago

tobynguyen commented 5 years ago

General information

Issue description

App Store Connect sends warning after uploading the app, that it contains a deprecated API usage of UIWebView. (ITMS-90809: Deprecated API Usage)

I don't know it's a false positive warning from the App Store side or what, but I keep getting this warning 2 weeks ago.

sestevens commented 5 years ago

Hi @tobynguyen. The Braintree SDK relies on a dependency called CardinalMobile that uses UIWebView. We should have a release of the Braintree SDK out soon that contains an updated version of CardinalMobile without UIWebView.

We'll post here once the release is out, and then you'll need to run pod update to get the latest version of the base Braintree SDK. You can also follow along with this issue in the base SDK repo.

vlasov commented 4 years ago

Hey @sestevens Braintree pod has been updated 3 days ago.. https://github.com/braintree/braintree_ios/issues/481#issuecomment-554534034

sestevens commented 4 years ago

Updating to the latest version of the base Braintree SDK (version 4.30.2) should resolve this issue for users of Braintree Drop-In. If you're using Cocoapods, you'll need to run pod update.

vlasov commented 4 years ago

@sestevens pod update will not have any effect, because Braintree Drop-In SDK is configured to use particular version of Braintree SDK. In BraintreeDropIn.podspec file you can see:

    s.dependency "Braintree/Core", "~> 4.29"
    s.dependency "Braintree/UnionPay", "~> 4.29"
    s.dependency "Braintree/PaymentFlow", "~> 4.29"
    s.dependency "Braintree/PayPal", "~> 4.29"

You have to update podspec and release a new version on BraintreeDropIn cocoapod in order to resolve this issue

sestevens commented 4 years ago

Hi @vlasov. The ~> 4.29 syntax pins to version 4.29 and higher, up to (but not including) version 5.0. Since the fix was released in version 4.30.2, pod update should allow you to update to this version.