Closed felixkrautschuk closed 3 years ago
scannillo
commented
3 years ago š Hello - happy to do my best to help here.
Question: so things work OK when you include braintree_ios v5, right? You said things break when you include braintree-ios-drop-in v9? Does that mean you're including both braintree_ios and braintree-ios-drop-in when they break, or solely braintree-ios-drop-in?
felixkrautschuk
commented
3 years ago @scannillo thanks for the fast reply.
I add only
pod 'BraintreeDropIn', '9.2.0'
and then I see this bunch of error messages.
Just for testing, I replaced that line by
pod 'Braintree', '5.4.3'
and the project built successfully.
So I never include both pods at the same time.
scannillo
commented
3 years ago Thanks for that clarification. When you include pod 'Braintree', '5.4.3' - is that the only Braintree specific line in your Podfile? Are you including any additional Braintree subspecs in your Podfile, or just the default Braintree?
felixkrautschuk
commented
3 years ago Yes, it is the only Braintree sprecific line, no additional subspecs.
scannillo
commented
3 years ago I wonder if you add the line pod 'Braintree/ThreeDSecure', '5.4.3' alongside pod 'Braintree', '5.4.3' if that then causes that build to fail? I see a few references to CardinalMobile, our 3DS provider, in that log, so I am curious.
felixkrautschuk
commented
3 years ago I just tested that and as a result I also get this bunch of error messages during the build.
scannillo
commented
3 years ago Ah, OK. So BraintreeDropIn (on SPM) includes BraintreeThreeDSecure by default (see code here). Seems like the issue is coming from BraintreeThreeDSecure (CardinalMobile), then.
We could send CardinalMobile a bug report, however it will be hard without the ability to replicate. Would you be able to come up with steps to replicate or be able to send us a sample project that replicates the issue?
I will say that Braintree doesn't officially offer support for NativeScript integrations. But, if you're able to provide us more on how to replicate, that would help!
felixkrautschuk
commented
3 years ago I created a sample project here: https://drive.google.com/file/d/1580FjvzK38pnxF9KjfQB31Evf-JXzeC0/view?usp=sharing
I pre-generated the native xcode project, which can be found at <root-dir>/platforms/ios.
It seems to be some issue with NativeScript, because when I create a new ios app project in xcode and add the BraintreeDropIn pod there, this project will be built as expected.
But maybe you could just have a look at the demo app provided above or give us more details about what has changed between version 8.1.4 and 9.x. I checked the changelog of course, but most of the breaking changes are related to the code and not to the build process.
scannillo
commented
3 years ago š Hi again. So when I clone your sample project, errors are coming from pretty much all of Apple's own frameworks. Example: HealthKit, Accelerate, WebKit, GameKit, etc. Also even when I bump BraintreeDropIn, in the Podfile, down to v8, I still get build errors.
Since I can't replicate these error messages by using the Braintree SDKs in a standard Xcode / iOS integration, I think this is more likely some issue with NativeScript setting up its iOS / Xcode environment & SDKs.
Since we don't offer official support for NativeScript integrations I am going to close this issue. If you would like to submit a feature request that we add support for NativeScript, you can do so here where we can gauge community interest.
Integration Details (please complete the following information):
Describe the bug I am trying to migrate the BraintreeDropIn pod version from 8.1.4 to 9.x.y in our cross-platform NativeScript project, which is based on Objective-C for iOS. Everything was working with version 8.1.4 and even when integrating the core braintree pod Braintree 5.4.3 instead of BraintreeDropIn (just for testing), the project is build correctly. But when adding the pod BraintreeDropIn 9.2.0 (also 9.1.0 or 9.0.0), the proect is not getting built with thousands of error messages.
The migration guide just says
We are working with Xcode 12.5. and I have set the following in our build.xcconfig:
Even if you do not know or support NativeScript, maybe you could give us a direction where the errors could come from.
Here is the first part of the error log (full log file is provided at the end)
...
Full error log: https://github.com/NativeScript/ns-v8ios-runtime/files/6854946/build_log.txt
To Reproduce As we cannot exclude the possibility that this issue is caused by the NativeScript framework in some way (even though there were no issues with version 8.1.4), we can't give any steps to reproduce this for you. But maybe you can give us some hints from having a look at those error logs.
Expected behavior Project should be able to built using the latest BraintreeDropIn pod (even in a NativeScript project).
Screenshots