search

braintree / braintree-ios-drop-in

Braintree Drop-in for iOS
https://developers.braintreepayments.com
MIT License
98 stars 77 forks source link

Add Error Message for Card Already Exists #364

Closed sarahkoop closed 2 years ago

sarahkoop commented 2 years ago

Summary of changes

Testing

Was tested by pointing our Package.swift to the fix branch:

.package(name: "Braintree", url: "https://github.com/braintree/braintree_ios", .branch("fix-card-already-exists-error-construction"))

We tested the demo app from there using a client token with passing failOnDuplicatePaymentMethod as true. There is not currently an integration test for this as the client token used for the test will expire and this flag cannot be passed with a tokenization key. In the future we will explore a better way to test these edge cases with generating a client token on a server.

Visuals

Gif Photo
Simulator Screen Recording - iPod touch (7th generation) - 2022-01-14 at 14 56 36 Simulator Screen Shot - iPod touch (7th generation) - 2022-01-14 at 15 26 40

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

sarahkoop commented 2 years ago

Putting do not merge until we can confirm with test client token that this is working correctly