search

braintree / braintree-ios-drop-in

Braintree Drop-in for iOS
https://developers.braintreepayments.com
MIT License
98 stars 77 forks source link

iOS 13 deprecation issue - `setNetworkActivityIndicatorVisible` #379

Closed hristo0624 closed 2 years ago

hristo0624 commented 2 years ago

SDK iOS 13 deprecation issue

After integrating latest SDK version 9.6.1 and run on the xcode it shows following error on the BTVaultManagementViewController file.

Please let me know how to solve this issue.

BraintreeDropin_iOS13

jaxdesmarais commented 2 years ago

Hello @hristo0624 -

It looks like setNetworkActivityIndicator was indeed deprecated in iOS 13 and due to our Demo target being iOS 12, were not seeing these warnings. We will work to get this upgraded in a future version of the Drop-in SDK.

Temporarily, I would recommend updating your build settings to not treat the deprecation warning as a compiler error so you can still use the SDK until we get a new version out.

scannillo commented 2 years ago

Hi @hristo0624 - we are working on a fix for this and will have a PR up soon. In the meantime, you can turn off "Treat Warnings as Errors" in your Build Settings.

scannillo commented 2 years ago

👋 Hi @hristo0624 - these deprecated method usages were removed in v9.7.0. Thank you for filing this issue!

nikitalpopov commented 2 years ago

Hi 😊 I still get error in XCode 14.0 and BraintreeDropIn 9.7.0. Any ideas why?

jaxdesmarais commented 2 years ago

Hello @nikitalpopov -

Would you mind clarifying the target iOS version of your application as well as the settings you have enabled? Xcode hitting the else block seems like it's more likely to be an Apple bug since that else block would be valid for targets lower than iOS 13.

nikitalpopov commented 2 years ago

@jaxdesmarais iOS 13 is the target version so I guess that's the root cause of the issue.

EdwinAlvrdo commented 1 year ago

I'm still have this issue, iOS 14 as target. XCode 14.2, Mac Silicon M1 pro. :(

In my podfile i have just one dependency >> pod 'BraintreeDropIn'

My minimum deployment is 14.0, even in my podfile config

![Uploading Screenshot 2023-01-08 at 1.18.57 PM.png…]()

andrii-lisovskiy commented 1 year ago

Still reproducing on my Xcode 14.3.1 and BraintreeDropIn (9.8.2)

scannillo commented 1 year ago

👋 Hi @andrii-lisovskiy - can you open a new issue with steps to replicate / screen shots?

andrii-lisovskiy commented 1 year ago

@scannillo Done -> Issue.