search

braintree / braintree-ios-drop-in

Braintree Drop-in for iOS
https://developers.braintreepayments.com
MIT License
98 stars 77 forks source link

Fix UnionPay Deprecation Issue #401

Closed mlazari closed 1 year ago

mlazari commented 1 year ago

Thank you for your contribution to Braintree.

Before submitting this PR, note we cannot accept language translation PRs. We support the same languages that are supported by PayPal, and have a dedicated localization team to provide the translations. If there is an error in a specific translation, you may open an issue and we will escalate it to the localization team.

Summary of changes

Some UnionPay deprecation issues were silenced in https://github.com/braintree/braintree-ios-drop-in/pull/387, but Braintree SDK added new deprecations in version 5.21.0 ( https://github.com/braintree/braintree_ios/pull/950 ). This change silences the new deprecation errors.

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

scannillo commented 1 year ago

Hey @mlazari - thank you for opening this PR contribution to Braintree iOS Drop In! Can confirm PR resolves the deprecation warnings for my sample app 👏.

I left a tiny nitpick comment, but otherwise looks great. Once this gets two 👍 from Braintree/PayPal devs, we will merge it in.

mlazari commented 1 year ago

@scannillo Thank you! I committed your suggestion.

scannillo commented 1 year ago

Closing in favor of https://github.com/braintree/braintree-ios-drop-in/pull/403, since I don't have push access to this fork to address build failures.