braintree / braintree-ios-drop-in

Braintree Drop-in for iOS
https://developers.braintreepayments.com
MIT License
98 stars 77 forks source link

Support for 6.X Braintree pod #418

Open khoogheem opened 1 year ago

khoogheem commented 1 year ago

Is your feature request related to a problem? Please describe.

Support Braintree 6.X

Currently the drop in only supports up to next major

[!] CocoaPods could not find compatible versions for pod "Braintree/ApplePay":
  In Podfile:
    Braintree/ApplePay (= 6.2.0)

    BraintreeDropIn (= 9.8.2) was resolved to 9.8.2, which depends on
      Braintree/ApplePay (~> 5.19)

Specs satisfying the `Braintree/ApplePay (= 6.2.0), Braintree/ApplePay (~> 5.19)` dependency were found, but they required a higher minimum deployment target.

Describe the solution you'd like.

our current setup is:

    pod 'BraintreeDropIn', '9.8.2'
    pod 'Braintree/ApplePay', '5.22.0'

and can't update to 6.x until drop in allows

scannillo commented 1 year ago

👋 Hello @khoogheem - thank you for opening this issue with us.

I have asked our product team to add updating Drop-In to use the latest Braintree iOS v6 to our development roadmap. We will keep you posted when we are able to get this work prioritized.

For internal tracking - ticket DTBTSDK-2832.

scannillo commented 1 year ago

Just an update here, @jaxdesmarais spiked out this change and found that we'll likely have to convert Drop In to Swift in order to update to braintree_ios V6 (due to a Swift lang bug; see forum 1 and forum 2).

While this still not on our current roadmap due to limited staffing, we will keep this ticket open as it is a necessary change to make.

We encourage folks to comment here who also need this update to help increase priority.

aj2109 commented 10 months ago

Good morning,

Any movement on this? Would be nice to have the project move onto the latest Braintree.

Many thanks,

Adam

scannillo commented 10 months ago

👋 Hi @aj2109 - thank you for commenting on this issue, it helps our product team get a sense of priority & need. Updating DropIn to braintree_ios V6 is an upcoming work-stream for our team. As we have updates, we will keep you posted!

aj2109 commented 9 months ago

Thank you @scannillo, appreciate the update.

aj2109 commented 7 months ago

Hello, any updates on timelines for the above? @scannillo

KushanF commented 7 months ago

Hi @scannillo Is there an update on this? Most Braintree fraud protection features recommend that the latest version of BT is used. But the drop-in UI is not at the same level. This becomes a blocker for businesses that are paying for the advanced fraud prevention features but can't use it to its full potential

jaxdesmarais commented 7 months ago

Hey all -

We do not currently have a timeline for this work but will keep this thread updated as we have updates.

Additionally @KushanF iOS v5 has access to the same advanced fraud protection tools as iOS v6. If you are running into issues with a specific subset of advanced fraud protection features please open a new issue with those details as they should be unrelated to iOS v5 vs iOS v6.

sellingsolutions commented 2 weeks ago

@jaxdesmarais Hello 👋 Bumping this as we've received a request to upgrade but are not able to due the same reasons mentioned in this thread. Is there an updated timeline on when we'll be able to upgrade to iOS Drop-In SDK 9.13.0?

image (3)
jaxdesmarais commented 2 weeks ago

Hello @sellingsolutions -

Braintree Drop-in v9.13.0 includes the new certificates and was released on May 7th, 2024.

khoogheem commented 2 weeks ago

Pod spec is still at 9.12.2

jaxdesmarais commented 2 weeks ago

@khoogheem -

Apologies, you are correct, it looks like the CHANGELOG was updated incorrectly but the release was not actually done. I'll get this updated and released ASAP. Thanks for calling this out! I'll update here once it's actually released.

jaxdesmarais commented 2 weeks ago

@sellingsolutions @khoogheem -

Drop-in version 9.13.0 has now been properly released. Thanks again for bring this to our attention!

sellingsolutions commented 2 weeks ago

@sellingsolutions @khoogheem -

Drop-in version 9.13.0 has now been properly released. Thanks again for bring this to our attention!

Thank you!

priyankaghosh-ios commented 1 week ago

Hello @all While updating the BraintreeDropIn pod to 9.13.0, getting the following error as my Braintree version, i have updated to 6.17.0

In Podfile: Braintree (= 6.17.0) was resolved to 6.17.0, which depends on Braintree/PayPal (= 6.17.0)

BraintreeDropIn (= 9.13.0) was resolved to 9.13.0, which depends on
  Braintree/PayPal (~> 5.26)

Any solution please.

khoogheem commented 1 week ago

depending on what parts of Braintree you need you can set the version to 5.26.0 like:

    pod 'BraintreeDropIn', '9.13.0'
    pod 'Braintree/ApplePay', '5.26.0'
    pod 'BraintreeDropIn', '9.13.0'
    pod 'Braintree/PayPal', '5.26.0'
priyankaghosh-ios commented 1 day ago

depending on what parts of Braintree you need you can set the version to 5.26.0 like:

    pod 'BraintreeDropIn', '9.13.0'
    pod 'Braintree/ApplePay', '5.26.0'
    pod 'BraintreeDropIn', '9.13.0'
    pod 'Braintree/PayPal', '5.26.0'

According to the mail I receive from Braintree that we have to update Braintree at least in 6.17.0 and BraintreeDropIn in 9.13.0. If we update pod 'Braintree/ApplePay', '5.26.0', pod 'Braintree/PayPal', '5.26.0' It is conflicting with Braintree version 6.17.0. So in conclusion I am unable to update Braintree '6.17.0' and BraintreeDropIn '9.13.0' simultaneously. How to resolve it. Thanks

khoogheem commented 1 day ago

as far as I know Dropin won't work with anything in the 6X range.. the most current that works with DropIn is the 5.26.0

do you also just do pod Braintree ??

You don't need to use both Braintree and Braintree/PayPal This should be all you really need

pod 'BraintreeDropIn', '9.13.0'
pod 'Braintree/PayPal', '5.26.0'

the default subspecs are Core, Card and PayPal if you look at the Braintree podspec

jaxdesmarais commented 1 day ago

@priyankaghosh-ios -

Drop-in version 9.13.0 contains Braintree 5.26.0 which also includes the updated certificates. You do not need to update to Braintree v6 if using the Drop-in as this is currently not possible (see replies above for additional details).

priyankaghosh-ios commented 1 day ago

@priyankaghosh-ios -

Drop-in version 9.13.0 contains Braintree 5.26.0 which also includes the updated certificates. You do not need to update to Braintree v6 if using the Drop-in as this is currently not possible (see replies above for additional details).

Thanks a lot