Add aria-hidden to generic card icon and aria-required to Hosted Fields

braintree / braintree-web-drop-in

Braintree Drop-in for the web

MIT License

200 stars 127 forks source link

Add aria-hidden to generic card icon and aria-required to Hosted Fields #910

Closed jplukarski closed 11 months ago

jplukarski commented 11 months ago

Summary

Adds the aria-hidden label to the generic card icon in the upper left corner of the cardview so that screenreaders do not read it. Also, adds the aria-required label to the input in the hosted fields so screen readers can accurately indicate it is a required field.

Checklist

[x] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@jplukarski

oscarleonnogales commented 11 months ago

Change looks good, but noticed the test isn't passing

jplukarski commented 11 months ago

Change looks good, but noticed the test isn't passing

Yep, fixed the failing unit and publishing tests!