search

braintree / braintree-web

A suite of tools for integrating Braintree in the browser
https://developer.paypal.com/braintree/docs/start/hello-client/javascript/v3
MIT License
444 stars 134 forks source link

Bump @braintree/sanitize-url from 6.0.0 to 6.0.1 #672

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps @braintree/sanitize-url from 6.0.0 to 6.0.1.

Changelog

Sourced from @​braintree/sanitize-url's changelog.

6.0.1

  • Fix issue where urls in the form javascript:alert('xss'); were not properly sanitized
  • Fix issue where urls in the form javasc	ript:alert('XSS'); were not properly sanitized
Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/braintree/braintree-web/network/alerts).
Intregrisist commented 1 year ago

https://github.com/advisories/GHSA-q8gg-vj6m-hgmj

gguerini commented 1 year ago

Is there anything preventing this PR to be merged?

gfrcsd commented 1 year ago

cc @crookedneighbor

jimbomags commented 1 year ago

is there a reason this hasn't been merged?

hollabaq86 commented 1 year ago

👋 folks, we're working on dependency updates in this library. Real quick though, I want to mention that the braintree-web library is not using sanitize-url in a way that is impacted by the security updates in v6.0.1 or 6.0.2.

Also, crookedneighbor is no longer with the company. Please don't @ him, me, or any of the maintainers of this library (I have rules that send github emails straight to my junk folder to help keep my work/life balance separated, I'm sure I'm not the only person in the Braintree org with this same setup 😄 ).

We're working on processes to keep the team better informed of updates to issues and PRs in our public repos, but as our team is small and our maintenance burden large, please understand it's going to take a minute to get those new processes in place and streamlined!

Thanks for your patience and understanding.

SancSalix commented 1 year ago

We'll be deploying the bump for this library ourselves so closing this. Deploy should occur sometime next week

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.