Fix 3DS Black Screen Bug on Android 14

braintree / braintree_android

Braintree SDK for Android

https://developer.paypal.com/braintree/docs/start/hello-client/android/v4

MIT License

407 stars 233 forks source link

Fix 3DS Black Screen Bug on Android 14 #1025

Closed sshropshire closed 4 months ago

sshropshire commented 4 months ago

Summary of changes

Fix issue that causes a black screen to display after successful 3DS validation
Make ThreeDSecureActivity transparency explicit via Activity theme

Screen Captures

Before

https://github.com/braintree/braintree_android/assets/58225613/0e4e2967-f19b-49c5-bb2a-e0077cdcf738

After

https://github.com/braintree/braintree_android/assets/58225613/fa3dc5e6-3bf5-411d-9f41-60ca4dbe1864

Checklist

[x] Added a changelog entry ~- [ ] Relevant test coverage~

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire

JRosielewska commented 2 months ago

Hi, with this fix (after updating Braintree to 4.49.1) I've noticed there is a side effect of black toolbar with app's name going from top to bottom after 3ds request screen I suspect, this is the effect of changing the Theme.Translucent style. If I override this style in my app and change the color of "android:windowBackground" to black rather than the transparent I can see that the black screen with toolbar is back and that's the reason of having just an animated toolbar when the windowdBackground is set to transparent:

Could you please advise any fix for this to not display the toolbar from 3ds screen?

I tried on android 31, 33, 34

Kind Regards, Justyna

JRosielewska commented 2 months ago

Hi, seems like the fix to above issue is to override this style: