App links feature - Githubissues

braintree / braintree_android

Braintree SDK for Android

https://developer.paypal.com/braintree/docs/start/hello-client/android/v4

MIT License

403 stars 231 forks source link

App links feature #1027

Closed saperi22 closed 1 month ago

saperi22 commented 1 month ago

Summary of changes

Merge app links feature into main

Checklist

[x] Added a changelog entry
[x] Relevant test coverage

Authors

List GitHub usernames for everyone who contributed to this pull request.

saperi22 commented 1 month ago

@tdchow any opinions on size of test classes? Detekt is failing on BraintreeClientUnitTest for large class.

tdchow commented 1 month ago

@tdchow any opinions on size of test classes? Detekt is failing on BraintreeClientUnitTest for large class.

Maybe we can add a suppress annotation for the test class and create a ticket to refactor it post-release. Also open to updating the detekt ruleset if folks would rather do that.

jaxdesmarais commented 1 month ago

Maybe we can add a suppress annotation for the test class and create a ticket to refactor it post-release. Also open to updating the detekt ruleset if folks would rather do that.

I would be fine suppressing it for the test class or updating the rule

tdchow commented 1 month ago

On second thought, maybe we update the rule for test classes.