braintree / braintree_android

Braintree SDK for Android
https://developer.paypal.com/braintree/docs/start/hello-client/android/v4
MIT License
403 stars 231 forks source link

Store Analytics Events as JSON Blobs in Room #1051

Closed sshropshire closed 1 week ago

sshropshire commented 2 weeks ago

Summary of changes

Checklist

~- [ ] Added a changelog entry~ ~- [ ] Relevant test coverage~

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire

tdchow commented 1 week ago

Will we need to make this same change on the v5 branch?

sshropshire commented 1 week ago

Will we need to make this same change on the v5 branch?

@tdchow Yeah there are a few things that need to be migrated. For the most part though we should be able to cherry-pick some commits or checkout the individual files to ensure that all changes are captured.

sarahkoop commented 1 week ago

@sshropshire were you able to validate that the data is making it to FPTI correctly formatted with this change?

sshropshire commented 1 week ago

@sarahkoop I still need to do that. I can follow up.

sshropshire commented 1 week ago

@sarahkoop confirmed!