[AppSwitch] Update PayPal Classes

braintree / braintree_android

Braintree SDK for Android

https://developer.paypal.com/braintree/docs/start/hello-client/android/v4

MIT License

409 stars 235 forks source link

[AppSwitch] Update PayPal Classes #1102

Closed richherrera closed 2 months ago

richherrera commented 2 months ago

Summary of changes

Update the feature branch with the latest changes from main.
Update the PayPal.kt classes with the logic previously developed in the PayPal.java classes.

PR reference: https://github.com/braintree/braintree_android/pull/1083 https://github.com/braintree/braintree_android/pull/1084 https://github.com/braintree/braintree_android/pull/1086 https://github.com/braintree/braintree_android/pull/1092

Checklist

[ ] Added a changelog entry
[x] Relevant test coverage

Authors

@richherrera

tdchow commented 2 months ago

The changes look good! I'm just commenting and not approving since we're merging this into the feature branch.

sarahkoop commented 2 months ago

Same looks good to me - is the next step to merge main into the app-switch-feature branch and then update this PR to be merged into that branch?

richherrera commented 2 months ago

Same looks good to me - is the next step to merge main into the app-switch-feature branch and then update this PR to be merged into that branch?

This PR is a merge between the feature-branch and main. I created it to have better control and review when moving the logic implemented in Java. The next step is to merge this PR into the feature branch. I think I made it more complicated than necessary 😄