[Tech Debt] Remove BraintreeHttpClient Convenience Methods - Githubissues

braintree / braintree_android

Braintree SDK for Android

https://developer.paypal.com/braintree/docs/start/hello-client/android/v4

MIT License

409 stars 235 forks source link

[Tech Debt] Remove BraintreeHttpClient Convenience Methods #1117

Closed sshropshire closed 2 months ago

sshropshire commented 2 months ago

Summary of changes

This PR removes http-verb-named convenience methods on BraintreeHttpClient and replaces them with two methods:
- sendRequest()
- sendRequestSync()
Both new methods take a BraintreeHttpRequest object to hold HTTP verb, target path, data, etc. parameters
This will make code more DRY and provide a foundation for a clean refactor of ConfigurationLoader and Http multithreading logic in the Core SDK

Checklist

[ ] ~Added a changelog entry~
[x] Relevant test coverage

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire