search

braintree / braintree_android

Braintree SDK for Android
https://developer.paypal.com/braintree/docs/start/hello-client/android/v4
MIT License
403 stars 232 forks source link

Add `venmo_installed` Analytics tag #991

Closed KunJeongPark closed 3 months ago

KunJeongPark commented 4 months ago

Summary of changes

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

@KunJeongPark

KunJeongPark commented 3 months ago

Were you able to see the new events in FPTI for both installed and not installed cases?

I see it for uninstalled (....91b&venmo_installed=false&gasn=AS..) in Jupyter notebooks but I don't have a working Android phone with Venmo installed. How do I simulate Venmo installed scenario on simulator? Sai is testing it for me on Android device with Venmo installed.

Tim tested it for me on real device and it looks like it is not returning true for Venmo installed scenario, so I will take a look.

Sai helped me and we found the source, we were not writing venmo_installed values into database. Sai tested on his phone, now the values are properly sent.