search

braintree / braintree_dotnet

Braintree .NET library
https://developer.paypal.com/braintree/docs/start/overview
MIT License
136 stars 73 forks source link

Feature Request: Add ExpirationYear and ExpirationMonth fields to PaymentMethodNonceDetails class #107

Closed glennsdavis closed 3 years ago

glennsdavis commented 3 years ago

General information

Issue description

The XML response from /merchants/{merchant-id}/payment_method_nonces/{nonce} endpoint returns expiration-year and expiration-month tags. See attached response.txt.

response.txt

The API method Gateway.PaymentMethodNonce.Find which is the wrapper to this endpoint returns a PaymentMethodNonce class that contains a PaymentMethodNonceDetails class. The PaymentMethodNonceDetails class is missing ExpirationYear and ExpirationMonth fields. Can these fields be added?

crookedneighbor commented 3 years ago

Yeah, they should be added. Would you like to open a PR? If not, we can add it to our backlog.

glennsdavis commented 3 years ago

We can open a PR. What is the procedure to do this? I am not able to create a branch.

On Friday, February 26, 2021, 06:53:25 AM PST, Blade Barringer <notifications@github.com> wrote:

Yeah, they should be added. Would you like to open a PR? If not, we can add it to our backlog.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

crookedneighbor commented 3 years ago

Typically you would fork the repo, then make a branch, and do a pull request: https://docs.github.com/en/github/getting-started-with-github/fork-a-repo

hollabaq86 commented 3 years ago

👋 quick update we merged #109 and will close this issue when those additions have been released

hollabaq86 commented 3 years ago

Version 5.4.0 is out with these changes! Thanks again for the PR 😄