braintree / braintree_dotnet

Braintree .NET library

https://developer.paypal.com/braintree/docs/start/overview

MIT License

136 stars 73 forks source link

adds FromNonceAsync to CreditCardGateway #97

Closed ronnieoverby closed 4 years ago

ronnieoverby commented 4 years ago

Summary

The credit card gateway has a FromNonce method without an async counterpart. This PR adds it.

Checklist

[ ] Added changelog entry
[x] Ran unit tests (See README for instructions)

ronnieoverby commented 4 years ago

Any initial thoughts about pulling this in?

crookedneighbor commented 4 years ago

@ronnieoverby This is an undocumented method, and likely up for deprecation, so I'm not sure we want to add an async method here. Are you using FromNonce, or did you just notice that it didn't have an async method?

ronnieoverby commented 4 years ago

We are using it to get a credit card that drop-in is responsible for vaulting. Please don't deprecate it!

sestevens commented 4 years ago

@ronnieoverby We've merged in this change, and it will be in the next release.

hollabaq86 commented 4 years ago

👋 @ronnieoverby your additions just got added in version 4.18.0, thanks again for the PR!