braintree / braintree_ios

Braintree SDK for iOS
https://developer.paypal.com/braintree/docs/start/hello-client/ios/v5
MIT License
560 stars 294 forks source link

[DO NOT REVIEW] Fix unit test testLargerMixedJSONWithEmoji() #1203

Closed warmkesselj closed 6 months ago

warmkesselj commented 8 months ago

Summary of changes

Fix testLargerMixedJSONWithEmoji().

This test is failing locally because URL(String: String) -> URL? returns a URL even with incorrectly URL formatted Strings. Addicating a REGEX check fixes this problem.

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

jaxdesmarais commented 6 months ago

Closing in favor of https://github.com/braintree/braintree_ios/pull/1244 since this PR is quite out of date, if we want to take this URL approach instead, lets open a new PR with the BTJSON changes!