search

braintree / braintree_ios

Braintree SDK for iOS
https://developer.paypal.com/braintree/docs/start/hello-client/ios/v5
MIT License
557 stars 291 forks source link

Bump BT v5 To Xcode 15.0.1 & Swift 5.9+ #1231

Closed agedd closed 4 months ago

agedd commented 5 months ago

Summary of changes

Apple is requesting that apps submitted to the App Store Connect must be built with Xcode 15 here.

Checklist

Authors

List GitHub usernames for everyone who contributed to this pull request.

agedd commented 5 months ago

hmm seems like CI is failing with this error: xcode-select: error: invalid developer directory '/Applications/Xcode_15.1.app' looking into how to resolve this but seems to be working fine locally 😅

scannillo commented 5 months ago

hmm seems like CI is failing with this error: xcode-select: error: invalid developer directory '/Applications/Xcode_15.1.app' looking into how to resolve this but seems to be working fine locally 😅

You might need to bump the MacOS version to get access to the Xcode 15 image? Sometimes macos-latest doesn't properly pull in the latest

agedd commented 5 months ago

hmm seems like CI is failing with this error: xcode-select: error: invalid developer directory '/Applications/Xcode_15.1.app' looking into how to resolve this but seems to be working fine locally 😅

You might need to bump the MacOS version to get access to the Xcode 15 image? Sometimes macos-latest doesn't properly pull in the latest

ahhh thanks, that was it! updating to macOS-14 in the scripts fixed it 🚀

agedd commented 4 months ago

We've talked in a few other PRs about also bumping the Package.swift and podspec to Swift 5.9. I think we can likely do the same here (I've added a ticket next sprint to do the same on v6)

sweet, addressed here!