braintree / braintree_ios

Braintree SDK for iOS
https://developer.paypal.com/braintree/docs/start/hello-client/ios/v5
MIT License
557 stars 291 forks source link

PaymentFlow Privacy Manifest #1236

Closed KunJeongPark closed 4 months ago

KunJeongPark commented 5 months ago

Summary of changes

Privacy Report Generated

Checklist

~- [ ] Added a changelog entry~

Authors

List GitHub usernames for everyone who contributed to this pull request.

KunJeongPark commented 4 months ago

We need to add the corresponding changes to Package.swift and Braintree.podspec files for this as well

Sorry @jaxdesmarais not sure what you mean. This one just adds Privacy manifest file to PaymentFlow module.

jaxdesmarais commented 4 months ago

Sorry @jaxdesmarais not sure what you mean. This one just adds Privacy manifest file to PaymentFlow module.

We also need to add an entry to those files to reference the manifests. See Package.swift entry and Braintree.podspec entry as an example

KunJeongPark commented 4 months ago

My goodness, I just blanked on that. Thanks Jax Here is the fix: 96c1b07c1d4a953358561ea6da3479683b6e32d3 and b553b5544a54a928f0f992738de068c7d149d6d9 and here: 28c3be2d2b6f104a7991723e0bb74f898045fc23 Sorry, u can just look at the composite. Syntax is a bit different here than 6.x