`Do not embed` Core in `Shopper Insights` framework

braintree / braintree_ios

Braintree SDK for iOS

https://developer.paypal.com/braintree/docs/start/hello-client/ios/v5

MIT License

557 stars 291 forks source link

`Do not embed` Core in `Shopper Insights` framework #1281

Closed richherrera closed 2 months ago

richherrera commented 2 months ago

Summary of changes

Change the embedding method used in the Shopper Insights framework to resolve distribution issues with the Demo app. This will standardize the embedding approach of the Braintree Core framework with those used in the other frameworks within the Demo app

Checklist

~[ ] Added a changelog entry~

Authors

@richherrera

richherrera commented 2 months ago

resolve distribution issues with the Demo app

Just curious what distribution issues we saw that this change resolves

Sure, this issue arose when trying to upload the Demo App to TestFlight. Upon review, we noticed that the frameworks that depend on Core are configured as Do Not Embed. Shopper Insights is the only one with the dependency set to Embed & Sign

Screenshot 2024-04-24 at 9 40 43 a m